Repository navigation
Make employees and absences evaluator tables sortable (65435) - #361
Merged
Merged
Conversation
linusfromscratch
deleted the
feature/65435-evaluator-sortable-columns
branch
September 7, 2026 09:46
Kagemaru
added a commit
that referenced
this pull request
Sep 14, 2026
- EvaluatorHelper#vacations hardcoded end_of_year instead of the period end date. - AbsencesEval#vacations_value read the ambient @period instead of its own period argument, so it always fell back to the current year. - EmployeesEval#vacations_value (from #361) independently duplicated the same end_of_year bug for the vacations sort column. - remaining_vacations now takes an explicit period argument; format is a :short/:long/:none enum instead of a boolean. - vacations is now an alias for remaining_vacations. - Added regression tests for past and future period end dates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.