Skip to content

chore(deps): upgrade Vite+ to 1.0.0, Vitest to 5.0.1, and Effect to 4.0.0-rc.118 - #82

Merged
altaywtf merged 1 commit into
mainfrom
chore/vite-plus-1.0
Sep 28, 2026
Merged

altaywtf merged 1 commit into
mainfrom
chore/vite-plus-1.0

Conversation

@altaywtf

Copy link
Copy Markdown
Member

Summary

Moves the toolchain to Vite+ 1.0.0 (Vitest 5.0.1) and Effect to 4.0.0-rc.118. @effect/vitest rc.118 is the first release that accepts Vitest 5 as a peer, and it requires effect ^4.0.0-rc.118, so both upgrades land together.

Changed

  • pnpm-workspace.yaml, package.json: catalog to Vite+ 1.0.0 / Vitest 5.0.1; effect, @effect/platform-node, @effect/platform-node-shared, @effect/vitest and the platform-node-shared override to 4.0.0-rc.118. minimumReleaseAgeExclude admits the rc.118 packages and the ten Vite+ 1.0.0 packages until they clear the 7-day release age.
  • src/cli-*.ts (9 files, import paths and constructor names only): Effect rc moved the CLI module from effect/unstable/cli to effect/cli and renamed its constructors to PascalCase (Flag.string → Flag.String, Flag.boolean → Flag.Boolean, Flag.integer → Flag.Int, Flag.choice/Argument.choice → Literals, Argument.file/path → File/Path, GlobalFlag.setting → GlobalFlag.Setting). The RokitGlobalFlagContext service ids follow the new effect/cli/GlobalFlag/<id> prefix. No logic changes.
  • AGENTS.md, vite.config.ts: the effect/cli path, and the coverage note no longer says "vitest 4".

Risks

  • Effect is still a release candidate; this pins exact rc.118.
  • pnpm install warns about unmet chokidar/gcp-metadata peers (via nunjucks/mongodb); the same warnings exist on main.

Verification

  • pnpm exec vp run verify: pass (check, skillcheck, tsc, pack, bin smoke, 16 files / 165 tests with coverage thresholds, npm pack --dry-run).
  • CLI output is unchanged against the published @putdotio/rokit@2.4.7: --help, describe, --json describe, press --help, wait-ready --help diff clean.
  • Error paths still render without stack traces: --json press → Missing required argument: key; --output bogus check → invalid-choice JSON error.
  • Not run: live:smoke / live:probe (need a Roku device).

Follow-Ups

  • Vitest 5 coverage.autoAttachSubprocess could cover the spawned dist/rokit.mjs and let src/rokit.ts back into coverage; left out to keep coverage numbers unchanged here.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T15:35:20.260076Z 2be7a31 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@altaywtf
altaywtf merged commit 0eff81e into main Sep 28, 2026
6 checks passed
@altaywtf
altaywtf deleted the chore/vite-plus-1.0 branch September 28, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant