chore(deps): upgrade Vite+ to 1.0.0, Vitest to 5.0.1, and Effect to 4.0.0-rc.118 - #82
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the toolchain to Vite+ 1.0.0 (Vitest 5.0.1) and Effect to 4.0.0-rc.118.
@effect/vitestrc.118 is the first release that accepts Vitest 5 as a peer, and it requireseffect ^4.0.0-rc.118, so both upgrades land together.Changed
pnpm-workspace.yaml,package.json: catalog to Vite+ 1.0.0 / Vitest 5.0.1;effect,@effect/platform-node,@effect/platform-node-shared,@effect/vitestand theplatform-node-sharedoverride to 4.0.0-rc.118.minimumReleaseAgeExcludeadmits the rc.118 packages and the ten Vite+ 1.0.0 packages until they clear the 7-day release age.src/cli-*.ts(9 files, import paths and constructor names only): Effect rc moved the CLI module fromeffect/unstable/clitoeffect/cliand renamed its constructors to PascalCase (Flag.string→Flag.String,Flag.boolean→Flag.Boolean,Flag.integer→Flag.Int,Flag.choice/Argument.choice→Literals,Argument.file/path→File/Path,GlobalFlag.setting→GlobalFlag.Setting). TheRokitGlobalFlagContextservice ids follow the neweffect/cli/GlobalFlag/<id>prefix. No logic changes.AGENTS.md,vite.config.ts: theeffect/clipath, and the coverage note no longer says "vitest 4".Risks
pnpm installwarns about unmetchokidar/gcp-metadatapeers (vianunjucks/mongodb); the same warnings exist onmain.Verification
pnpm exec vp run verify: pass (check, skillcheck, tsc, pack, bin smoke, 16 files / 165 tests with coverage thresholds,npm pack --dry-run).@putdotio/rokit@2.4.7:--help,describe,--json describe,press --help,wait-ready --helpdiff clean.--json press→Missing required argument: key;--output bogus check→ invalid-choice JSON error.live:smoke/live:probe(need a Roku device).Follow-Ups
coverage.autoAttachSubprocesscould cover the spawneddist/rokit.mjsand letsrc/rokit.tsback into coverage; left out to keep coverage numbers unchanged here.