Repository navigation
ci: run the scan and link check in verify - #89
Conversation
Replace the Scan and Links caller workflows with the shared putdotio/.github scan and links actions as the last steps of CI's verify job. Release now calls that job through workflow_call instead of keeping its own copy, so the push run on main is the release run's verify and scans the pushed range, while CI keeps pull requests and gains manual dispatch for the full-history scan.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
It restructures the release/CI pipeline and removes the Scan/Links workflows, so a human should confirm no branch-protection required status checks still reference the removed workflow names before merging.
Review effort: Balanced
Findings: None
What changed in this PR
This PR consolidates CI so the Markdown link check and the secret/workflow scan run as the final steps of CI's single Verify Roku app job instead of as separate Links and Scan workflows. It replaces the two standalone workflows with the shared composite actions putdotio/.github/.github/actions/{links,scan}@v1.2.0, and rewires release.yml's verify job to call ci.yml via workflow_call so a main push runs verification (and the push-range scan) inside the release run. Documentation (AGENTS.md, CONTRIBUTING.md, docs/RELEASE.md) is updated to match the new topology.
Changes:
- Add
workflow_call+workflow_dispatchtriggers toci.yml, scopecancel-in-progressto pull-request runs only, and append thelinksandscansteps (scan guarded by!cancelled()). - Delete
links.ymlandscan.yml;release.yml'sverifyjob nowuses: ./.github/workflows/ci.yml, dropping the duplicated job definition. - Update three docs to describe the new CI/Release flow, pointing at the shared actions.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds workflow_call/workflow_dispatch triggers, PR-only cancel, and links/scan steps as the final verify steps. |
.github/workflows/release.yml |
Verify job now calls ci.yml via workflow_call instead of defining its own steps. |
.github/workflows/scan.yml |
Removed; scanning moved into CI's verify job via the shared action. |
.github/workflows/links.yml |
Removed; link checking moved into CI's verify job via the shared action. |
AGENTS.md |
Rewords Delivery bullets to describe the shared links/scan steps and new flow. |
CONTRIBUTING.md |
Updates CI/Delivery description to the consolidated CI job and release call. |
docs/RELEASE.md |
Clarifies that main pushes run the same CI job from the release workflow and scan the pushed range. |
I verified: the pinned SHA c1830f7… matches tag v1.2.0; the scan action passes through on pull requests, scans the range on push (which reaches ci.yml as github.event_name == 'push' through workflow_call), and self-deepens the persist-credentials: false shallow checkout with contents: read; the !cancelled() guard and PR-only cancel-in-progress match the shared action's documented requirements; the #actionsscan/#actionslinks anchors exist; and no remaining references to the deleted workflows exist in the repo.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The secret and workflow scan and the Markdown link check now run as the last steps of CI's
Verify Roku appjob, and Release calls that job instead of keeping its own copy..github/changes)mainrelease.ymlalready runs on everymainpush and gates semantic-release on verify, so itsverifyjob now callsci.ymlthroughworkflow_call. CI keeps one trigger per job (pull requests, plus manual dispatch for the full-history scan with no release side effects), and the push scan runs inside the release run with the push range. This also drops the duplicated verify job definition.actions/linksandactions/scanfrom putdotio/.github v1.2.0, pinned by commit. CI concurrency now cancels only pull-request runs.main: verify through CI, then semantic-release, which releases nothing for aci:commit, so the deploy job stays skipped.pnpm verify,actionlint, andzizmorclean; the links action's command passes on this branch and fails on a seeded broken link.Written by an agent (Claude Code, Claude Opus 5.5)