Skip to content

Add Release section - #6

Merged
gemmaro merged 1 commit into
purs-jp:jafrom
daaa1k:add-release-section
Feb 21, 2026
Merged

Add Release section#6
gemmaro merged 1 commit into
purs-jp:jafrom
daaa1k:add-release-section

Conversation

@daaa1k

@daaa1k daaa1k commented Feb 20, 2026

Copy link
Copy Markdown

What

The Release section has been added to the top page, as in the original work.
Also, that has been translated.

Why

It has been missing in the translation.
#5 (comment)

@daaa1k
daaa1k marked this pull request as ready for review February 20, 2026 00:43
@daaa1k daaa1k mentioned this pull request Feb 20, 2026

@gemmaro gemmaro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Below aren't directly related to the review points, just for future reference.


The release information fragment could be integrated into the po4a process, but the messages in that fragment are trivial and don't amount to a reason to change the steps.

The reason the heading of the release section wasn't parsed as Markdown is due to the exact rule for HTML blocks in the seventh start-end condition. ☝️🤓

Comment thread .github/workflows/mdbook.yml
Comment thread .github/workflows/mdbook.yml Outdated
@daaa1k

daaa1k commented Feb 20, 2026

Copy link
Copy Markdown
Author

The release information fragment could be integrated into the po4a process, but the messages in that fragment are trivial and don't amount to a reason to change the steps.

I agree with you.

@daaa1k
daaa1k force-pushed the add-release-section branch from a6d9a8c to fa090d3 Compare February 21, 2026 01:42
@daaa1k
daaa1k requested a review from gemmaro February 21, 2026 01:43
@gemmaro

gemmaro commented Feb 21, 2026

Copy link
Copy Markdown
Member

Thank you, sounds good to me

@gemmaro
gemmaro merged commit 632842b into purs-jp:ja Feb 21, 2026
3 checks passed
@daaa1k
daaa1k deleted the add-release-section branch February 21, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants