Skip to content

codeclimate (GitLab Code Quality compatible) output support #79

Merged
chelnak merged 3 commits into
puppetlabs:mainfrom
alexjfisher:code_climate2
Feb 28, 2023
Merged

codeclimate (GitLab Code Quality compatible) output support #79
chelnak merged 3 commits into
puppetlabs:mainfrom
alexjfisher:code_climate2

Conversation

@alexjfisher

@alexjfisher alexjfisher commented Jan 23, 2023

Copy link
Copy Markdown

An alternative to #78

Once/if this is accepted, I'll open a pdk-templates PR to add support there.

Comment thread lib/puppet-lint/report/codeclimate.rb Outdated
Comment thread lib/puppet-lint/report/codeclimate.rb Outdated
@alexjfisher alexjfisher force-pushed the code_climate2 branch 4 times, most recently from f272197 to 9dc19bb Compare February 14, 2023 11:44
@alexjfisher alexjfisher changed the title WIP: codeclimate output support (take 2) codeclimate (GitLab Code Quality compatible) output support Feb 14, 2023
@alexjfisher alexjfisher marked this pull request as ready for review February 14, 2023 11:48
@alexjfisher alexjfisher requested a review from a team as a code owner February 14, 2023 11:48
@alexjfisher alexjfisher requested a review from ekohl February 14, 2023 12:15
Comment thread lib/puppet-lint.rb Outdated
@alexjfisher alexjfisher force-pushed the code_climate2 branch 2 times, most recently from 028ad1d to 7729aa1 Compare February 14, 2023 17:25
Comment thread lib/puppet-lint.rb Outdated
@alexjfisher alexjfisher force-pushed the code_climate2 branch 2 times, most recently from a3b33ea to 37e27d0 Compare February 14, 2023 21:49
@alexjfisher alexjfisher requested a review from ekohl February 14, 2023 21:52

@ekohl ekohl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A future improvement would be to factor out stdout to its own class (something like a8df415, but then tested and cleaned up).

Comment thread spec/fixtures/test/reports/code_climate.json Outdated
@chelnak chelnak merged commit 5accc62 into puppetlabs:main Feb 28, 2023
@chelnak chelnak added the feature New feature or request label Feb 28, 2023
@alexjfisher

Copy link
Copy Markdown
Author

Related PDK change in puppetlabs/pdk-templates#499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants