Conversation
`Control#filtered_profiles_levels` used `.concat` (union) when both `--select-profile` and `--select-level` were given. This caused `profiles_levels_by_level` to return all profiles at the requested levels — including `workstation` — regardless of what was passed via `-p`. The fix changes `.concat` to `&` (intersection) so only entries matching both filters are returned. A second guard in `MarkdownGenerator#generate` defaults `select_profile` to `['server']` for `sce_linux` when no `-p` flag is provided at all, covering invocations that omit the flag entirely. The guard is extracted into a private `default_profile_for_sce_linux!` helper to avoid increasing the cyclomatic complexity of `generate`. Version bumped to 0.18.8. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
pocketgeek
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Control#filtered_profiles_levelsused.concat(union) when both--select-profileand--select-levelwere given, causingworkstationentries to appear in the generated REFERENCE.md even when-p server,...was explicitly passed.concatto&(intersection) so only entries matching both the profile and level filters are returneddefault_profile_for_sce_linux!guard inMarkdownGeneratorthat defaultsselect_profileto['server']forsce_linuxwhen no-pflag is provided, covering the no-flag caseTest plan
bundle exec rspec spec/abide_dev_utils/sce/benchmark_spec.rb— includes new intersection test (passes for sce_linux, skips for sce_windows which has no workstation controls)bundle exec rspec spec/abide_dev_utils/sce/generate/reference/markdown_generator_spec.rb— three unit tests for the opts-defaulting behaviorsce_linuxcontains noworkstationentries when run with-p server,...or without-p🤖 Generated with Claude Code