added the download image button - #3
Conversation
Added an option to download the graph as a png for future reference,
|
Hey @punnerud , any update on this ? |
|
@blueprintparadise Thanks for this, and sorry for the wait. The feature is wanted and it is included in #4 — with the export moved to the client side, and you credited via The reason for changing the implementation rather than merging as-is: the server-side version re-plots the graph with Three other things that would have bitten in production:
Also, the imported If you would rather have the server-side route as well — for scripting or automation, where there is no canvas to read — that is a reasonable thing to want and I would take a follow-up PR for a Superseded by #4, but the feature is yours — leaving this open for @punnerud to decide. |
|
@blueprintparadise Your feature is shipped and released — it is in Closing this one because it can no longer be merged: the conflicts GitHub is showing are in exactly the three files that moved or went away when the project became a pip package — For the record, the reason for the swap rather than a straight merge: If you still want a server-side route for scripting — where there is no canvas to read — that is a reasonable thing to want and I would take a fresh PR for a |
The same text as mpedb and MPEqs, byte for byte, so the three projects share one licence rather than three that can drift apart. Free of charge for every person and every organization, except that a group over five billion dollars in revenue or valuation owes seven US cents per device, once. The OSI classifier is removed rather than swapped: this licence is not OSI approved, and "License :: OSI Approved :: MIT License" would have been a false claim in the package metadata. It now reads Other/Proprietary, and the LICENSE file ships inside the wheel. ONE THING WORTH KNOWING BEFORE THIS GOES OUT. This repository has had outside contributions, and PR #3's author is credited with Co-authored-by on the download-image commit. Their work was offered when the project said MIT. In practice nothing of theirs remains in the tree -- that feature was reimplemented on the client side, and the server-side version it replaced is not in any current file -- so this is a relicensing of code that is ours. It is still worth recording that the question was asked rather than skipped. Version 0.4.0, because the licence a package is distributed under is not a patch-level detail.
The same text as mpedb and MPEqs, byte for byte, so the three projects share one licence rather than three that can drift apart. Free of charge for every person and every organization, except that a group over five billion dollars in revenue or valuation owes seven US cents per device, once. The OSI classifier is removed rather than swapped: this licence is not OSI approved, and "License :: OSI Approved :: MIT License" would have been a false claim in the package metadata. It now reads Other/Proprietary, and the LICENSE file ships inside the wheel. ONE THING WORTH KNOWING BEFORE THIS GOES OUT. This repository has had outside contributions, and PR #3's author is credited with Co-authored-by on the download-image commit. Their work was offered when the project said MIT. In practice nothing of theirs remains in the tree -- that feature was reimplemented on the client side, and the server-side version it replaced is not in any current file -- so this is a relicensing of code that is ours. It is still worth recording that the question was asked rather than skipped. Version 0.4.0, because the licence a package is distributed under is not a patch-level detail.
Added an option to download the graph as a png.