fix(launcher): improve game path auto detection#292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Game path auto-detection could fail when the INI registry path pointed at HKEY_LOCAL_MACHINE, because the launcher stripped the HKLM prefix and only read HKCU. Users then had to manually choose the game executable even when the install path was available from registry or a standard install location.
Fix
Teach detect_game_path to build registry lookup candidates from the INI hive prefix.
Explicit HKEY_LOCAL_MACHINE paths now read HKLM first, with HKCU as a compatibility fallback. Explicit HKEY_CURRENT_USER paths read HKCU, while unprefixed paths keep the historical HKCU-first behavior and then try HKLM.
If registry detection still returns empty, fall back to common Program Files install paths using the INI executable template to derive the game exe name. Successful registry or default-path detections are written back to Config.xml for future launches.
Updates frontend callers to pass the INI exe template, regenerates bindings, and adds regression coverage for HKLM-prefixed registry detection plus default install-path candidate generation.
Closes #284