fix(launcher): extract locale emulator files to appdata#291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
LocaleRemulator support files were being extracted next to the running executable/current app path. This could leave released files outside the app data directory while
Config.xmlalready lives under%APPDATA%\Beanfun.Fix
Use
AppState::storage_rootas the launcher extraction/staging target directory, so LocaleRemulator files are released under the same%APPDATA%\Beanfunroot asConfig.xml.The launcher command now builds its
LaunchRequest.target_dirfrom the managed app storage root instead of resolving the executable parent directory. The obsolete command-layer target-dir resolution error path was removed, bindings were regenerated, andCargo.lockwas synced to6.0.0.Adds regression coverage that the launch request uses the storage root as the LocaleRemulator target directory.
Closes #285