Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds optional support for syncing of DEP11 metadata files, enabling the use of application stores like KDE Discover which are based on Appstream.
I reworked PR #1277 for the current main because the it was developed on basis of version 3.5, which caused a lot of conflicts trying to rebase.
I mark this as draft, because i'm not sure how to handle the feature toggle correctly and would like some input. As of right now, the toggle only affects the syncing part. This in turn means that if a repo is syncing with DEP11 sync enabled and the flag is disable afterwards, the synced DEP11 files are still present and published.
My question would be how this should be handled correctly. Options i see are:
I'll also re-evaluate how to write tests for this feature but @hstct's comment from the last PR still stands. I just want to get the review / feedback rolling for now.