Repository navigation
[PULP-2500] Deactivate local DistributedPublication in favour of pulpcore's - #1546
Conversation
f533db6 to
4d5a872
Compare
|
This doesnt add new functional test, because the existing tests for distributed content should just keep working: pulp_deb/pulp_deb/tests/functional/api/test_download_content.py Lines 179 to 209 in e3a91d7 |
There was a problem hiding this comment.
Given this is a follow up/cleanup task for #925, the tests have remained green, I trust those involved, and I also don't use this feature myself, I am tempted to wave this through.
However, before I do, I would like to give the original contributor of the original change @daviddavis, as well as his teammate @acheng-01 (whom it is my understanding has inherited David's role from then) a chance to weigh in.
Do either of you want to review this before I end up simply approving and merging it?
Give me today to review for any potential breaking issues on our end. I'll report back in a bit. |
|
Thanks for the review. |
This deactivates the use of DistributedPublication, as the content app is already using pulpcore's version effectively. It doesn't remove the tables (yet) to ensure zero-downtime-upgrades don't fail. That should be done in a future commit/release. Closes: pulp#1430 Assisted-by: GPT-6-Luna
4d5a872 to
050ebc0
Compare
This deactivates the use of DistributedPublication, as the content app is already using pulpcore's version effectively. It doesn't remove the tables (yet) to ensure zero-downtime-upgrades don't fail. That should be done in a future commit/release.
Closes: #1430
Assisted-by: GPT-6-Luna
📜 Checklist
See: Pull Request Walkthrough