Repository navigation
PULP-2717: Fix UnboundLocalError in content app _match_and_stream #1712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
decko
wants to merge
1
commit into
pulp:main
Choose a base branch
from
decko:pulp-2717-unbound-local-var
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| Fixed a 500 (``UnboundLocalError: cannot access local variable '_'``) in the content app | ||
| ``pulpcore/content/handler.py`` ``_match_and_stream``. Patch 0080 used a bare ``_`` as the | ||
| throwaway target of three tuple unpacks, which made ``_`` a function-local name and shadowed | ||
| gettext's ``_``. Requests for a distribution with no repository, publication, or remote reached | ||
| the "Distribution is not pointing to..." branch without executing any of those unpacks, so the | ||
| gettext call raised ``UnboundLocalError`` and the content app returned 500 instead of 404 | ||
| (PULP-2717). The same shadowing turned upstream fetch failures into | ||
| ``TypeError: 'QuerySet' object is not callable``. The unpacks now use ``_lazy_queryset``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium · Correct 404 response fails assertion
When the handler correctly returns a 404 with the distribution message in the response body,
test_empty_distribution_returns_404fails at line 48:requests.Response.reasonis the HTTP status phrase (Not Found), not the response body containing the distribution message, so the assertion rejects the correct 404.Check
response.textfor the distribution message instead ofresponse.reason.Prompt for AI agents