Repository navigation
Attest PyPI release build provenance - #1063
Conversation
|
FYI @mdellweg |
|
This is SLSA build provenance as opposed to the kind provided by Trusted Publishing https://docs.pypi.org/using-pypi/package-security/provenance/#attestation-types |
| - name: "Attest package build provenance" | ||
| uses: "actions/attest-build-provenance@v3" | ||
| with: | ||
| subject-path: "dist/*" | ||
|
|
There was a problem hiding this comment.
Is this producing files in "dist/"? Can we maybe move this to the build workflow to not sign something that we uploaded as an artifact and downloaded on another worker already?
There was a problem hiding this comment.
I had the same thought but I think it ultimately doesn't matter much as long as the artifacts are the same as what is uploaded.
There was a problem hiding this comment.
Well, that is my worry in a nutshell. We don't know nothing can temper artifacts created by one workflow before they are downloaded again.
And adding it this way could be creating a false sense of security.
There was a problem hiding this comment.
I mean the same applies with having a publish job separate from the build job in the first place (it also uses the download artifacts action). I don't think singling out the attestation task makes sense.
Also, how far does that logic go, because can we trust GHA in the first place? If we can't trust the upload/download actions, can we trust what is built there at all? Can we trust the attestations they provide? Trusted Publishing? etc.
There was a problem hiding this comment.
Basically what I'm getting at is that the attestation and publish tasks both operate on the same artifacts downloaded by line 45. I don't think it's a concern necessarily, but if it is it's a pre-existing one.
Add GitHub build provenance attestations for plugin and Python client distributions published to PyPI. Assisted By: Codex
Add GitHub build provenance attestations for plugin and Python client distributions published to PyPI.
Assisted By: Codex
📜 Checklist
See: Pull Request Walkthrough