Skip to content

Separate sanity checks - #1016

Merged
mdellweg merged 2 commits into
pulp:mainfrom
mdellweg:rearrange_sanity_checks
Mar 12, 2026
Merged

mdellweg merged 2 commits into
pulp:mainfrom
mdellweg:rearrange_sanity_checks

Conversation

@mdellweg

Copy link
Copy Markdown
Member

No description provided.

@mdellweg
mdellweg force-pushed the rearrange_sanity_checks branch 5 times, most recently from e73ef90 to 67cd99c Compare March 11, 2026 08:20
@mdellweg
mdellweg marked this pull request as ready for review March 11, 2026 09:15
- name: "Check for common gettext problems"
run: |
sh .ci/scripts/check_gettext.sh
{%- endif %}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call all of these - maybe except check_manifest and bump version - as linting.
They read some source files and flag if they follow a rule or not.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only distiction between lint and sanity is that sanity does not prevent the tests from running.
So in case you want to see if X is working (e.g. by using a not yet released commit on a dependency) you can do so, but it will still reject to being merged.
I'm open to discuss what checks belong to which category.
"wrong use of gettext" actually sounds like linting...

@mdellweg
mdellweg force-pushed the rearrange_sanity_checks branch from 67cd99c to 60557ee Compare March 11, 2026 12:46
@mdellweg
mdellweg enabled auto-merge (rebase) March 12, 2026 10:41
Comment thread .github/workflows/ci.yml Resolved
@mdellweg
mdellweg force-pushed the rearrange_sanity_checks branch from ef648b4 to 8b6b60e Compare March 12, 2026 14:37
@mdellweg
mdellweg merged commit fe1b004 into pulp:main Mar 12, 2026
13 checks passed
@mdellweg
mdellweg deleted the rearrange_sanity_checks branch March 12, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants