Open
Conversation
d460c10 to
964266f
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors hardware register assignment code to use macros for improved maintainability and fixes a configuration-dependent module name reference. The changes introduce a new header file with register assignment macros and update the register interface code to use these macros instead of repetitive manual assignments.
Key changes:
- Introduced
rdl_assign.svhheader with macros for register read/write acknowledgment assignments - Refactored register interface assignments in
slink.svto use the new macros and intermediate signals - Fixed module name from
i_serial_link_networktoi_serial_link_protocolin wave configuration
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/include/rdl_assign.svh | New header file defining macros for RDL register read/write acknowledgment assignments |
| src/slink.sv | Refactored register interface code to use new macros and intermediate signals; added include directive |
| Bender.yml | Added include directory configuration for the new header file |
| util/wave.tcl | Fixed module instance name from network to protocol layer |
Comments suppressed due to low confidence (1)
src/include/rdl_assign.svh:15
- The macro
SLINK_SET_RDL_WR_ACKhas incorrect logic. It's checking~reg2hw.field.req_is_wr(NOT write request) but should checkreg2hw.field.req_is_wr(IS write request) to match the write acknowledgment semantics. This is inconsistent withSLINK_ASSIGN_RDL_WR_ACKon line 9.
`define SLINK_SET_RDL_WR_ACK(field, hw2reg = hw2reg, reg2hw = reg2hw) \
hw2reg.field.wr_ack = reg2hw.field.req & reg2hw.field.req_is_wr;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3015be2 to
291ec6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.