Skip to content

Bump slang to v11 #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
micprog wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump slang to v11 #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/bender-slang/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ include(FetchContent)
FetchContent_Declare(
slang
GIT_REPOSITORY https://github.com/MikePopoloski/slang.git
GIT_TAG v10.0
GIT_TAG v11.0
GIT_SHALLOW TRUE
)
FetchContent_MakeAvailable(slang)
Expand Down
11 changes: 6 additions & 5 deletions crates/bender-slang/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,15 @@ fn main() {
println!("cargo:rustc-link-lib=static=svlang");

// Link the additional libraries based on build profile.
let (fmt_lib, mimalloc_lib) = match (target_env.as_str(), build_profile.as_str()) {
("msvc", _) => ("fmt", "mimalloc"),
(_, "debug") => ("fmtd", "mimalloc-debug"),
_ => ("fmt", "mimalloc"),
// Slang v11 bundles mimalloc directly into libsvlang.a (via mimalloc-obj),
// so only fmt needs an explicit link line.
let fmt_lib = match (target_env.as_str(), build_profile.as_str()) {
("msvc", _) => "fmt",
(_, "debug") => "fmtd",
_ => "fmt",
};

println!("cargo:rustc-link-lib=static={fmt_lib}");
println!("cargo:rustc-link-lib=static={mimalloc_lib}");

if target_os == "windows" {
println!("cargo:rustc-link-lib=advapi32");
Expand Down
2 changes: 1 addition & 1 deletion crates/bender-slang/cpp/rewriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) 2025 ETH Zurich
// Tim Fischer <fischeti@iis.ee.ethz.ch>

#include "slang/syntax/SyntaxVisitor.h"
#include "slang/syntax/SyntaxRewriter.h"
#include "slang_bridge.h"

#include <unordered_map>
Expand Down
Loading