Add GeoVI extension#474
Open
ptiede wants to merge 18 commits into
Open
Conversation
Lets GeoVI's `init`/`fit` be called without an explicit ξ0 for a geovi_likelihood-built ComposedLikelihood: returns a zero starting latent of size `dimension(tpost)`, with the array type taken from the data-likelihood's variance array Σ so it matches the backend (host or Reactant device). Dispatch keys on the forward being `forwardmodel`, so it only fires for geovi_likelihood likelihoods. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Removes ComradeGeoVIExt, the GeoVI weakdep/extension entries in Project.toml, and the geovi_likelihood stub so this PR is purely the ProbabilityTransports transition. The GeoVI work moves to the ptiede-geovi branch stacked on this one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Adds ComradeGeoVIExt: implements GeoVI's observation-space likelihood interface on VLBILikelihoods.ComplexVisLikelihood, provides geovi_likelihood to build a composed GeoVI likelihood from a standard-normal-standardized posterior, and a GeoVI.default_latent matching the data backend. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the GeoVI work out of #460 so that PR is purely the ProbabilityTransports transition.
What this adds
ext/ComradeGeoVIExt.jl: implements GeoVI's observation-space likelihood interface (logdensity,normalized_residual,transformation,leftsqrtmetric/rightsqrtmetric,fishermetric) directly onVLBILikelihoods.ComplexVisLikelihood— no bespoke wrapper type.geovi_likelihood(tpost)(stub insrc/posterior/transformed.jl, method in the extension): builds a composed GeoVI likelihood from a standard-normal–standardized posterior, so GeoVI's½‖ξ‖²reference prior exactly reproduces the standardized Comrade prior.GeoVI.default_latent: a zero starting latent sized todimension(tpost)with the array type taken from the data variance array, so it matches the problem's backend (host vs Reactant device).GeoVIweakdep +ComradeGeoVIExtentries inProject.toml.Notes
ptiede-ptransport) — the extension uses the ProbabilityTransports machinery (transport_to,transform,dimension). Once Start transition to ProbabilityTransports #460 merges this should retarget tomainautomatically.🤖 Generated with Claude Code