Repository navigation
Advisors: Advise, Proposal, the lookahead as the first advisor (carries the actors-seats merge) - #134
Merged
Merged
Conversation
The seat client and the station move from the commander app into recreation_towers_ground, with a headless computer commander (commander::run, binary towers_commander). The server no longer decides or sends plans: it starts a computer commander as a seat client for a computer team. A seat changes hands during a game: a person relieves a computer, and a computer takes a seat a person leaves. Two people can play. Co-Authored-By: Claude <noreply@anthropic.com>
…d reckoning; crash log lines Measured on SITL: the first version asked for AGENT in the middle of the take-off transition (two games lost a drone at its base), held its clock to one game second past the last map (slow plans at 10x) and planned from the position of the last report. The server prints what a crashed drone was doing and who was near. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
The computer commander in towers_ground now implements the Command trait's directive and sends each directive's queue over the seat. Co-Authored-By: Claude <noreply@anthropic.com>
The commander takes advice (not stale, gain over 2 points, still fits); a roster can give a team an advisor with a delay in game time. Expectations 18-advice, an advice example, and the results in plans/actors.md. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 4 (first half) of
plans/actors.md: advisors in the rules crate and the fast arena.This branch also carries the merge of
actors-seats(PR 131) intoactors-roster, as its first commit. One conflict:domains/teleoperation/command/src/seat.rs(the queue branch addedqueue: vec![]there, the seats branch turned it into a re-export of the moved file). Resolved by keeping the re-export and carrying the queue edit intotowers_ground/src/seat.rs.plans/actors.mdmerged with both Results notes. The computer commander intowers_ground::commanderis now driven as aCommandand sends each directive's queue over the seat (Seat::order_with_queue).World::command_standingbecame test-only (nothing calls it after the merge).What changed
recreation_towers::advice:trait Advise { fn advise(&mut self, view: &TeamView, hand: &Hand) -> Vec<Proposal>; fn clone_box(&self) -> Box<dyn Advise>; },Proposal { drone, order, queue, gain, made, until, why },Hand { orders, free, away }(what the commander has in hand and the map does not show) andLookahead, the old lookahead moved out ofCommanderwith the same model, cadence and numbers.Commanderholds advisors with a delay in game time (with_advisor,add_advisor). Each decision it takes the best proposal that is not stale, gains more thanADVICE_MARGIN(2 points, a constant:CommanderTuningis the league's candidate format) and still fits (drone free, tower not given up, and for a proposal made on an earlier map not a tower the team holds now).Commander::adviseputs proposals in hand from outside. A taken proposal's queue goes out with the directive.with_lookahead(false)is a commander with no advisor.Roster::with_advisor(team, advisor, delay),Command::advised_by,Captain::advised_by. The delay is game time, no threads.18-advice.expect(taken, small gain, stale, held now, no advisor), vocabulary in09-towers/section.expect, glossary terms Advisor and Proposal, a pointer in05-commander.expect.cargo run -p expectation -- check expectations: 0 errors. In therecreation_towersacceptance driver the suite's coverage mode reaches the first three; the last two only arranged and visited, sotests/acceptance.rshasmod adviceplaying all five by hand.cognition_towers --example advice.Advisoris unchanged; it carries no order or gain, so it is not anAdvise.Not done
The seat side (proposals over the wire, the app's accept), a queue in the lookahead's proposals, the Claude advisor.
Gate: same results
denial,ruleset v2 200andjudge --game captain --champion timid --challenger default --seeds 24were saved before and after, withSIM001_LOOKAHEADunset and0: all six pairs byte-identical. Onlyjudgeand the "default against default" line ofrulesetuse the lookahead (Blue wins 50 % with it, 68 % without);denialand the other policies play with it off.Gate: what advice is worth
cargo run --release -p cognition_towers --example advice 400: commander + lookahead advisor at the delay, against a commander with no advisor, 400 seeds, both sides (800 games each).By the default rules the lookahead is worth less than nothing in the arena, at every delay. Lateness up to 5 s changes nothing measurable; 30 s is worst. The reason is not measured.
Tests
cargo test --release -p recreation_towers -p cognition_towers -p recreation_towers_ground,-p recreation_towers_server --binsand-p cognition_league --libpass;cargo build --release -p recreation_towers_server -p teleoperation_commandbuilds; fmt and clippy clean in the repo's code.cognition_league'stests/acceptance.rswas not run (known to time out).🤖 Generated with Claude Code