Fix KeyError when GitLab event data lacks target_id#468
Open
BeeGrech wants to merge 1 commit into
Open
Conversation
Use .get('target_id') in Issue.iid(), Issue.body,
MergeRequest.__init__, and MergeRequest.body so that events or
objects missing target_id degrade gracefully instead of raising.
Add unit tests covering Issue, MergeRequest, and MergedRequest
with missing target_id and full_message enabled.
Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Brian Grech <bgrech@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Using
--full-messagewith a GitLab config crashes with:at
Issue.bodyandMergeRequest.body.Fix
Use
.get('target_id')inIssue.iid(),Issue.body,MergeRequest.__init__, andMergeRequest.bodyso that events orobjects missing
target_iddegrade gracefully instead of raising.Add unit tests covering
Issue,MergeRequest, andMergedRequestwith missing
target_idand--full-messageenabled.