add first WIP for allowing to get stats about created releases#314
add first WIP for allowing to get stats about created releases#314szaimen wants to merge 1 commit into
Conversation
|
Hi @psss can you please give me same additional pointers where I need to modify the code so that it starts working? Thanks in advance! :) |
6764221 to
baeb398
Compare
|
Thanks for the draft! You just need to include the new stats in the Lines 244 to 266 in a3a49fa Also make sure, that you correctly extract the list of projects from the Lines 235 to 239 in a3a49fa Let me know if anything else is not clear. |
psss
left a comment
There was a problem hiding this comment.
Nice kick-off! Thanks! In order to make it work we need the Release class though plus enabled the new stats under the GitHubStats class.
| url = https://api.github.com/ | ||
| token = <authentication-token> | ||
| login = <username> | ||
| project = <project1, project2> |
There was a problem hiding this comment.
| project = <project1, project2> | |
| project = <project1>, <project2> |
Let's make it a bit more clear that comma is a project separator here.
| query = "repos/{0}/releases?q=author:{1}+created:{2}..{3}".format( | ||
| project, self.user.login, self.options.since, self.options.until) | ||
| self.stats = [ | ||
| Releases(release) for release in self.parent.github.search(query)] |
There was a problem hiding this comment.
Is seems that you need to define the Release class as well. It could be similar to the Issue class above.
Signed-off-by: Simon L <szaimen@e.mail.de>
baeb398 to
823e5a8
Compare
Close #310