Repository navigation
Preserve verified plus addresses in dashboard signing links - #22
Open
YS-OH-CORE wants to merge 1 commit into
Open
YS-OH-CORE wants to merge 1 commit into
YS-OH-CORE wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21.
A contributor whose verified GitHub email is
name+label@example.comis shown as unverified because the dashboard compares its normalized group key (name@example.com) against the original verified addresses. Passing that stripped address to/sign/would also fail the sign view's exact verified-email check.This associates each pending group with an actual verified address from the session and uses that address in the displayed signing link. A verified untagged address is preferred when available, preserving the existing path; otherwise the first verified alias is used. The original address, including its plus tag, is URL-encoded and carried through signing.
The existing email-normalization policy and the sign view's verification checks are unchanged. This fixes the dashboard's choice of an already authorized address; it does not make an unverified address acceptable to
/sign/.Validation:
0da7e2e794f5714321f18212aafd86978fb00896source separately from the verification branch. This contributor-fork run is separate from upstream CI approval.makemigrations --checkpass in that Linux run; localgit diff --checkalso passes.AI assistance disclosure: This contribution was prepared for Youngseok Oh (@YS-OH-CORE) using OpenAI Codex for implementation, testing, and review.