Repository navigation
Add ErrWrongType, keep characters whole in quoted input - #7
Merged
Merged
Conversation
A JSON value of the wrong type, such as a number for ISO8601, was the only cause of an invalid duration that a caller could not test for: it had a message, "want a JSON string", but no sentinel. Its error now matches ErrWrongType. The message is unchanged. An error quotes at most 64 bytes of a bad input, and cut there even in the middle of a UTF-8 character, so the message ended in a replacement character that the input never held. The cut now moves back to the start of that character.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings 10 and 11 of the full review, in one pull request because both change
errors.go.ErrWrongType(new API). A JSON value of the wrong type, such as a number forISO8601or a string forSec,was the only cause of an invalid duration without a sentinel. Its error now matches
ErrWrongType, next toErrInvalidDuration. The message stays "want a JSON string", "number" or "string or number".put a replacement character into the message. The cut now moves back, by at most three bytes, to the start of the
character. Text that is not UTF-8 is cut at 64 bytes as before.
Tests cover characters of 2, 3 and 4 bytes at every position around the cut. Coverage stays at 100%.