Repository navigation
Show a wrapper type with options, correct a claim about Units - #5
Merged
Merged
Conversation
The wrapper types take no options, and nothing said what to do when a field needs AcceptDays or AlsoAccept and the call cannot take options. The README and an example now show a wrapper type of one's own. The README said that Units reads exactly what time.ParseDuration reads, with the same value, which the list of differences and the fuzz target itself contradict: fractions may differ by the last nanosecond.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings 8 and 9 of the full review.
documentation and a new example (
ExampleAcceptDays_ownWrapper, a whole-file example, so pkg.go.dev shows the typetoo) show the few lines it takes to give a field
AcceptDaysorAlsoAcceptwithout passing options to the call.time.ParseDuration. "How it is tested" saidUnitsreads exactly what it reads, with the same value. The listof differences further up and the fuzz target say otherwise: fractions may differ by the last nanosecond.