chore(sdk): bump @protolabsai/sdk 0.3.1 → 0.3.4 (fixes protoCLI#307) + smoke test#3870
Conversation
…e test 0.3.4 fixes the agentic-loop early-termination bug (protoCLI#307) where the agent emitted intent after planning then stopped without executing tools — surfacing in protoMaker as empty feature executions. Verified with a new isolated smoke test that mirrors ProtoProvider.executeQuery against the live gateway (write a file, read it back, assert it landed): 4/4 PASS on protolabs/smart (turns=7-8, toolUses=2 [write_file, read_file], result=success). Was intermittently failing on 0.3.1. - apps/server/package.json: ^0.3.1 -> ^0.3.4 (+ lockfile) - scripts/smoke/proto-sdk-smoke.mjs: durable, one-command smoke test (auto-loads repo-root .env, resolves the installed SDK, model + iteration args, exit-coded for CI) - docs/internal/server/proto-sdk-smoke-test.md: how/when to run + FAIL triage Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR introduces a Node-based smoke test ( ChangesProto SDK Smoke Test
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
QA Audit — PR #3870 | chore(sdk): bump @protolabsai/sdk 0.3.1 → 0.3.4 (fixes protoCLI#307) + smoke test
VERDICT: WARN (CI in progress — not blocking)
CI Status (head 325da64)
- test: in_progress
- build: in_progress
- deploy: in_progress
- checks: in_progress
Diff Review
Clean, narrow change: SDK pin bump (^0.3.1 → ^0.3.4) + lockfile update in apps/server/. No source changes to ProtoProvider — the PR correctly relies on SDK API compatibility. Added alongside:
scripts/smoke/proto-sdk-smoke.mjs— durable smoke test (ESM,.envauto-load, exit-coded for CI)docs/internal/server/proto-sdk-smoke-test.md— run guide + FAIL triage table- Nav entry in
docs/internal/index.md
Observations
- [LOW]: Smoke test script not yet tracked in CI pipeline — it's exit-coded and ready to drop into a
test:smokestep, but no GitHub Actions job references it. Recommend adding atest:smokejob (or at minimum a pre-merge note in the PR body) so the test actually gates future SDK bumps. - [LOW]: The
scripts/smoke/proto-sdk-smoke.mjsdiff was truncated in the diff output — could not review lines 50–152. Based on the file header and the documented behavior, the implementation looks sound (wrapsquery()withProtoProvider-matching options, writes to temp dir, assertsresult.txtexistence and content). Recommend confirming full content in the Files tab. - [INFO]:
node_modules/@protolabsai/sdkmoved from root-level toapps/server/node_modules/@protolabsai/sdkin the lockfile — expectedpnpm-monorepo behavior, not a functional concern.
CLAWPATCH: Skipped — since ref "main" invalid for this repo.
Preliminary PASS — the code is safe to merge and does exactly what it claims. Approval will be posted once CI clears green. The smoke test docs and script are high-value additions. Flag the test:smoke CI gap for follow-up.
— Quinn, QA Engineer
|
Submitted a preliminary COMMENT review on |
|
Docs preview: https://chore-bump-sdk-0-3-4.protolabs-docs.pages.dev |
Pulls in
@protolabsai/sdk0.3.4, which fixes the agentic-loop early-termination bug (protoCLI#307, closed as completed) — the agent emitted intent after the planning turn then stopped without executing tools, surfacing in protoMaker as empty feature executions.Verification
New isolated smoke test (
scripts/smoke/proto-sdk-smoke.mjs) mirrorsProtoProvider.executeQuery'squery()invocation against the live gateway: it runs a 2-step task that requires tool use after planning (writeresult.txt, read it back) and asserts the file actually landed.4/4 PASS on
protolabs/smart(the bug was intermittent on 0.3.1).tsc --noEmitclean — 0.3.4 is API-compatible with ourProtoProvider/ClaudeProviderusage (no source changes needed).Changes
apps/server/package.json:^0.3.1→^0.3.4(+package-lock.json)scripts/smoke/proto-sdk-smoke.mjs: durable one-command smoke test — auto-loads repo-root.env, resolves the installed SDK, takesmodel+iterationsargs, exit-coded for CI.docs/internal/server/proto-sdk-smoke-test.md: when/how to run + FAIL triage table + how it maps toProtoProvider.Follow-up
Unblocks crew dispatch (protoMaker#81), which was gated on this SDK fix. Recommend a full end-to-end validation (restart the prod instance on this build, dispatch one real feature) before re-enabling auto-mode at scale.
🤖 Generated with Claude Code
Summary by CodeRabbit
Dependencies
@protolabsai/sdkto v0.3.4Documentation
Tests