Skip to content

chore: remove deploy-main workflow#3648

Merged
mabry1985 merged 1 commit into
mainfrom
chore/remove-deploy-main-workflow
May 24, 2026
Merged

chore: remove deploy-main workflow#3648
mabry1985 merged 1 commit into
mainfrom
chore/remove-deploy-main-workflow

Conversation

@mabry1985
Copy link
Copy Markdown
Contributor

@mabry1985 mabry1985 commented May 24, 2026

Production deploy is no longer driven by GitHub Actions — handled out-of-band. The workflow's required runner label (`protolabs`, exclusive to `protolabs-main`) has been offline, so every main push was producing a stuck/queued job.

What's removed

  • `.github/workflows/deploy-main.yml`
  • Updated `docs/internal/dev/system-architecture.md` Release Flow section to drop the `3. deploy-main.yml fires` step

Follow-up

A separate PR will pull the remaining `ubuntu-latest` and `self-hosted` workflows onto the `namespace-profile-protolabs-linux` runner so we stop consuming GitHub Actions minutes.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Refactored deployment infrastructure and updated documentation to reflect changes in the release workflow process.

Review Change Stack

Production deploy is no longer driven by GitHub Actions — handled
out-of-band. The workflow's required runner label (\`protolabs\`,
exclusive to \`protolabs-main\`) was offline anyway, so every main
push was producing a stuck/queued job.

Also updates docs/internal/dev/system-architecture.md to drop the
"3. deploy-main.yml fires" step from the Release Flow diagram.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@mabry1985 mabry1985 enabled auto-merge (squash) May 24, 2026 00:35
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e6244d2d-b069-4fa6-ac4a-40387029dd85

📥 Commits

Reviewing files that changed from the base of the PR and between cb587ab and 331f4e0.

📒 Files selected for processing (2)
  • .github/workflows/deploy-main.yml
  • docs/internal/dev/system-architecture.md
💤 Files with no reviewable changes (1)
  • .github/workflows/deploy-main.yml

📝 Walkthrough

Walkthrough

The PR removes the deploy-main GitHub Actions workflow and updates the CI/CD Release Flow documentation. Version sourcing is changed to libs/types/package.json, and the post-release deployment description is updated to reflect an out-of-band model with workflows chained from release tags instead of automatic deployment on main branch pushes.

Changes

Deployment Model Update

Layer / File(s) Summary
CI/CD documentation update
docs/internal/dev/system-architecture.md
Release flow now sources version from libs/types/package.json, removes deploy-main.yml workflow description, and documents production deployment as out-of-band with workflows chained from release tags.

🎯 2 (Simple) | ⏱️ ~8 minutes


🐰 A workflow once ran with devoted care,
Deploy-main would always be there.
But now it's retired, the docs reflect new ways,
Out-of-band deploys greet the main branch these days.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: remove deploy-main workflow' directly and specifically describes the main change: the removal of the deploy-main workflow file. It clearly summarizes the primary action taken in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-deploy-main-workflow

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

Code Review — ? finding(s)

Async review running parallel to CodeRabbit. Findings are advisory; not all are merge blockers.

protoLabs Code Review Report

  • Generated: 2026-05-24T00:36:10Z
  • Git head: 4a2f32a63e44840675ea938b462de0b5c48a0a1a
  • Features mapped: 3
  • Findings: 0

No findings recorded.

@github-actions
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown

@protoquinn protoquinn Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by Quinn: safe PR class (dependabot/renovate/promote/chore(deps)) with passing CI.

@mabry1985 mabry1985 merged commit 817ad14 into main May 24, 2026
8 checks passed
@mabry1985 mabry1985 deleted the chore/remove-deploy-main-workflow branch May 24, 2026 00:38
mabry1985 added a commit that referenced this pull request May 24, 2026
Pulls 11 workflows off GitHub-hosted (\`ubuntu-latest\`) and ad-hoc
\`self-hosted\` onto \`namespace-profile-protolabs-linux\` — the same
runner already used by \`checks.yml\`, \`test.yml\`, and
\`langfuse-prompt-sync.yml\`. This stops consuming GitHub Actions
minutes for these workflows.

ubuntu-latest → namespace:
- code-review.yml
- idea-accepted.yml
- deploy-docs.yml
- close-external-prs.yml
- stale.yml
- triage.yml

self-hosted → namespace:
- auto-release.yml
- create-protolab-test.yml
- e2e-tests.yml
- regenerate-site.yml
- pr-check.yml

Untouched: \`deploy-main.yml\` (being removed in #3648 — was the only
workflow targeting the offline \`protolabs-main\` runner).

Co-authored-by: Automaker <automaker@localhost>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant