Skip to content

feat: add onXPostMediaClick - #591

Draft
ocavue wants to merge 1 commit into
masterfrom
feat/x-post-media-click
Draft

ocavue wants to merge 1 commit into
masterfrom
feat/x-post-media-click

Conversation

@ocavue

@ocavue ocavue commented Sep 18, 2026

Copy link
Copy Markdown
Member

X post cards fire a cancelable meowdown-embed-media-click event for photos and videos (videos now start from a poster button), and Editor and MarkdownView expose it as onXPostMediaClick so a host can show the media in its own lightbox.

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
meowdown Ignored Ignored Sep 18, 2026 6:49pm UTC

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

@pkg-pr-new

pkg-pr-new Bot commented Sep 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@meowdown/core@591
npm i https://pkg.pr.new/@meowdown/embed@591
npm i https://pkg.pr.new/@meowdown/markdown@591
npm i https://pkg.pr.new/@meowdown/react@591

commit: cfb4dc7

@github-actions

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 94.43% 5501 / 5825
🔵 Statements 92.2% 6206 / 6731
🔵 Functions 92.22% 1328 / 1440
🔵 Branches 88.48% 4125 / 4662
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/index.ts 0% 0% 0% 0%
packages/core/src/extensions/editor-config-types.ts 0% 0% 0% 0%
packages/core/src/extensions/extension.ts 100% 88.88% 100% 100%
packages/core/src/extensions/x-post-media-click.ts 100% 100% 100% 100%
packages/embed/src/x/index.ts 0% 0% 0% 0%
packages/embed/src/x/media-click.ts 100% 100% 100% 100%
packages/embed/src/x/render-media.ts 98.64% 87.3% 100% 100% 29
packages/embed/src/x/theme.css 0% 0% 0% 0%
packages/react/src/components/editor.tsx 76.92% 73.91% 72.72% 76.92% 453, 489-501
packages/react/src/components/markdown-view.tsx 96.2% 90.53% 97.87% 99.05% 255, 259, 400, 403-408, 475, 478, 549, 700, 749
packages/react/src/components/prosekit-editor.tsx 93.8% 89.74% 87.87% 95.09% 97, 108, 518, 591-600
Generated in workflow #2362 for commit cfb4dc7 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant