Repository navigation
release: @proofable/sdk 0.1.4 - fail closed on empty delegated allowlist - #4
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Runtime-mount permission evaluation now fails closed for delegated bundles whose mounted permission proof has an empty or missing
allowedActionslist.buildRuntimeBundlepreserves a present-but-emptyallowedActionsinstead of dropping the field, so "scoped to nothing" is never read as "unscoped".evaluateRuntimeActiondenies delegated actions when the allowlist is empty or absent, returningACTION_NOT_ALLOWED.Why
An empty delegated allowlist must grant nothing. Dropping the field turned a scoped-to-nothing delegation into a permissive mount.
Release
Version bumped
0.1.3 -> 0.1.4. After merge, push tagv0.1.4to trigger the Release workflow and publish@proofable/sdk@0.1.4.Verification
npm run lint- 0 errorsnpm test- 209/209 pass (16 files), including the new empty/absent allowlist and controller-authority casesnpm pack- artifact contains the fix inruntime-mount.js(lines 313 and 626)Acceptance:
@proofable/sdk@0.1.4empty delegatedallowedActions=> DENY; full tests pass; packed artifact contains the fix; npm registry reads back 0.1.4.