ksmd: Improve help text - #3782
Merged
Merged
Conversation
Member
Author
|
I also did a little bit of style cleanup. |
SuperQ
force-pushed
the
superq/ksm_format
branch
from
August 5, 2026 06:43
1248673 to
74e9cc5
Compare
Update the ksmd collector to use pre-defined metrics descriptions instead of auto-generated. This allows for improved help text taken from the kernel documentation. This also avoids memory allocations each time `NewKsmdCollector()` is called. Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
force-pushed
the
superq/ksm_format
branch
from
August 5, 2026 06:45
74e9cc5 to
3bb4025
Compare
Contributor
|
LGTM, the help texts are little more helpful now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the ksmd collector to use pre-defined metrics descriptions instead of auto-generated. This allows for improved help text taken from the kernel documentation. This also avoids memory allocations each time
NewKsmdCollector()is called.