Skip to content

Change label_replace and label_join test cases to fail when either legacy or UTF-8 name validation is enabled #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charleskorn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change label_replace and label_join test cases to fail when either legacy or UTF-8 name validation is enabled #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions promql/promql-test-queries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,15 +199,15 @@ test_cases:
- query: 'label_replace(demo_num_cpus, "job", "value-$1", "src", "(.*")'
should_fail: true
# label_replace fails when the destination label name is not a valid Prometheus label name.
- query: 'label_replace(demo_num_cpus, "~invalid", "", "src", "(.*)")'
- query: 'label_replace(demo_num_cpus, "\xff", "", "src", "(.*)")'
should_fail: true
# label_replace fails when there would be duplicated identical output label sets.
- query: 'label_replace(demo_num_cpus, "instance", "", "", "")'
should_fail: true
- query: 'label_join(demo_num_cpus, "new_label", "-", "instance", "job")'
- query: 'label_join(demo_num_cpus, "job", "-", "instance", "job")'
- query: 'label_join(demo_num_cpus, "job", "-", "instance")'
- query: 'label_join(demo_num_cpus, "~invalid", "-", "instance")'
- query: 'label_join(demo_num_cpus, "\xff", "-", "instance")'
should_fail: true
- query: '{{.dateFunc}}()'
variant_args: ['dateFunc']
Expand Down