Support registry as Pushgateway second argument#769
Open
bugprone wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jace <bugprone@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Pushgatewayaccepts an optionaloptionsargument before theregistryargument. In TypeScript,new Pushgateway(url, registry)was accepted becauseoptionswas typed asany, but at runtime that registry object was treated as request options and the Pushgateway fell back to the global registry.This makes the two-argument registry form work at runtime and declares it explicitly in the TypeScript definitions.
Fixes #652.
Changes
Registrypassed as the secondPushgatewayconstructor argument as the registrynew Pushgateway(url, registry)andnew Pushgateway(url, options, registry)Pushgateway.Optionstype withrequireJobNameplus request option passthroughTesting
npm test -- --runInBand --forceExitnew Pushgateway(url, registry).push()sends metrics from the provided registry