Skip to content

feat(template): Add addDuration template helper for time offsets #5550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
holger-waschke wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

feat(template): Add addDuration template helper for time offsets #5550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions template/template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,14 @@ var DefaultFuncs = FuncMap{
"mustToDate": func(layout, s string) (time.Time, error) {
return time.ParseInLocation(layout, s, time.UTC)
},
// addDuration parses ds as a Go duration, adds it to t, and returns the resulting Unix milliseconds.
"addDuration": func(t time.Time, ds string) (int64, error) {
d, err := time.ParseDuration(ds)
if err != nil {
return 0, err
}
return t.Add(d).UnixMilli(), nil
},
"toJson": func(v any) (string, error) {
bytes, err := json.Marshal(v)
if err != nil {
Expand Down
10 changes: 10 additions & 0 deletions template/template_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,6 +902,16 @@ func TestTemplateFuncs(t *testing.T) {
title: "Template using mustToDate with invalid input returns error",
in: `{{ mustToDate "2006-01-02" "not-a-date" }}`,
expErr: `template: :1:3: executing "" at <mustToDate "2006-01-02" "not-a-date">: error calling mustToDate: parsing time "not-a-date" as "2006-01-02": cannot parse "not-a-date" as "2006"`,
}, {
title: "Template using addDuration with valid input",
in: `{{ addDuration . "90m" }}`,
data: time.Unix(0, 0).UTC(),
exp: "5400000",
}, {
title: "Template using addDuration with invalid input returns error",
in: `{{ addDuration . "not-a-duration" }}`,
data: time.Unix(0, 0).UTC(),
expErr: `template: :1:3: executing "" at <addDuration . "not-a-duration">: error calling addDuration: time: invalid duration "not-a-duration"`,
}} {
t.Run(tc.title, func(t *testing.T) {
wg := sync.WaitGroup{}
Expand Down
Loading