Add mTLS support for remote write#192
Open
CharlieTLe wants to merge 1 commit into
Open
Conversation
Adds --tls-client-cert-file, --tls-client-key-file, and --tls-ca-cert-file flags so avalanche can authenticate to remote-write endpoints that require mTLS or a custom CA. ConfigWrite.TLSClientConfig now holds *tls.Config to avoid copying the embedded sync.RWMutex. A warning is logged when --tls-client-insecure is combined with --tls-ca-cert-file since the CA is silently bypassed in that case. Includes tests covering each flag combination and README documentation. Signed-off-by: Charlie Le <charlie_le@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds --tls-client-cert-file, --tls-client-key-file, and --tls-ca-cert-file flags so avalanche can authenticate to remote-write endpoints that require mTLS or a custom CA. ConfigWrite.TLSClientConfig now holds *tls.Config to avoid copying the embedded sync.RWMutex. A warning is logged when --tls-client-insecure is combined with --tls-ca-cert-file since the CA is silently bypassed in that case.
Includes tests covering each flag combination and README documentation.