feat(input): add per-target JSONL filters - #7597
Draft
3nesdeniz wants to merge 3 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Closes #4934.
This adds a target-oriented JSONL mode in which each URL can override
tags,exclude-tags,severity, and localtemplateswhile omitted fields inherit the corresponding global options:{"url":"https://target-a.example","tags":["apache","shiro"],"severity":["critical","high"]} {"url":"https://target-b.example","exclude-tags":["tomcat"],"templates":["http/cves/2026/"]} {"url":"https://target-c.example"}nuclei -l targets.jsonl -input-mode jsonlThe implementation:
-exclude-hostsbefore caching target records;MetaInputIDs, hashes, preflight keys, and multiformat behavior unchanged when no target overrides are present.For combinations whose child execution cannot yet preserve independent target criteria, the runner returns a clear error instead of silently bypassing filters. This currently covers automatic scan, workflows, and global matchers. Per-target template selectors are local-only and cannot be combined with global remote template URLs.
An explicitly empty field clears the inherited CLI selection. For
templates, this is equivalent to clearing-tand therefore falls back to the default template catalog.This is a draft so maintainers can confirm those boundary semantics before it is marked ready.
Proof
go test -race ./internal/runner ./pkg/input/provider/http ./pkg/input/formats/json ./pkg/protocols/common/contextargs ./pkg/core ./pkg/templatesgo test -tags=integration ./internal/tests/integration -run '^TestTargetJSONLTemplateFilters$' -count=1 -vgo vet -tags=integration ./internal/tests/integrationmake vetmake buildgit diff --checkThe complete local
make testrun reached four packages whose Interactsh tests could not register with the public OAST service. The same focused failures reproduce on an untouchedupstream/devworktree atbcf20899; all target-filter packages and integration scenarios above pass with the race detector where applicable.Checklist