passive exports - #7585
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe PR adds response extraction for Burp, JSON, and YAML inputs, routes embedded responses through offline HTTP execution, skips transformations for those responses, and prevents offline mode from automatically enabling DAST. ChangesOffline passive scanning
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant ExportedFormat
participant OfflineHTTP
participant TemplateExecutor
participant Matcher
ExportedFormat->>OfflineHTTP: provide request URL and response raw data
OfflineHTTP->>TemplateExecutor: execute embedded response
TemplateExecutor->>Matcher: evaluate response without input transformation
Matcher-->>TemplateExecutor: return operator result
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/protocols/offlinehttp/request.go`:
- Around line 41-54: Update the embedded-response branch in the request
execution flow around ReqResp.Response and executeRawInput so successful scans
increment the same progress/stat counter as the normal path before returning.
Reuse the existing IncrementRequests() mechanism and preserve the current
early-return behavior for the scan result.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9da4c61f-2f07-4184-8c28-5bdd7212e14c
📒 Files selected for processing (15)
internal/runner/runner.gointernal/server/nuclei_sdk.gopkg/input/formats/burp/burp.gopkg/input/formats/burp/burp_test.gopkg/input/formats/json/json.gopkg/input/formats/json/json_test.gopkg/input/formats/yaml/multidoc.gopkg/input/formats/yaml/multidoc_test.gopkg/protocols/offlinehttp/request.gopkg/protocols/offlinehttp/request_export_test.gopkg/tmplexec/flow/flow_internal.gopkg/tmplexec/generic/exec.gopkg/tmplexec/multiproto/multi.gopkg/tmplexec/utils/utils.gopkg/tmplexec/utils/utils_test.go
Summary
Closes #5414
Summary by CodeRabbit