Add filesize DSL and matcher offset for file protocol - #7571
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
WalkthroughThe change adds optional offset-pinned matching for words, binary data, and regexes. File protocol events now include total file size in DSL context, with validation and tests covering both features. ChangesMatcher and file context enhancements
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant processReader
participant buildEvent
participant responseToDSLMap
processReader->>buildEvent: pass totalBytes
buildEvent->>responseToDSLMap: pass fileSize
responseToDSLMap-->>buildEvent: InternalEvent with filesize
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Exposes filesize on file protocol events for DSL, and adds optional offset on word/binary/regex matchers so patterns can be pinned to a byte index (e.g. MZ at 0).
Closes #3340
Summary by CodeRabbit
New Features
Bug Fixes