Skip to content

fix(audit): log user for filtered requests #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverbaehler merged 2 commits into from
Aug 19, 2026
Merged

fix(audit): log user for filtered requests #1090

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8046ea9
fix(audit): log user for filtered requests
anisimov-es Aug 11, 2026
3b14c80
Update internal/webserver/webserver.go
oliverbaehler Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions internal/webserver/webserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,12 @@ func (n *kubeFilter) authorizationMiddleware(next http.Handler) http.Handler {
})
}

func (n *kubeFilter) handleRequest(request *http.Request, selector labels.Selector) {
func (n *kubeFilter) handleRequest(request *http.Request, selector labels.Selector, username string) {
// Requests handled with a selector are forwarded using the proxy ServiceAccount,
// so the Kubernetes audit event cannot retain the original user through
// impersonation. Record that identity before replacing the bearer token.
n.log.V(5).Info("proxying filtered request", "username", username, "method", request.Method, "uri", request.URL.Path)

req.SanitizeImpersonationHeaders(request)

selectorValue := selector.String()
Expand Down Expand Up @@ -649,7 +654,7 @@ func (n *kubeFilter) registerModules(ctx context.Context, root *mux.Router) {
// if there's no selector, let it pass to the
n.impersonateHandler(writer, request)
default:
n.handleRequest(request, selector)
n.handleRequest(request, selector, username)
}
})
}
Expand Down
Loading