fix(sles): bootstrap base packages separately - #1217
Open
djshah19 wants to merge 1 commit into
Open
Conversation
Install the SLES base userland before the application RPM and its runtime dependency graph. This prevents package scriptlets from invoking a partially installed shell while preserving the existing combined transaction for other RPM targets. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb0dc7e4-0a3b-4e0b-acdc-0807676acccc Signed-off-by: Dhwani Shah <dhwanishah@microsoft.com>
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
The scoped implementation preserves existing behavior by default and includes focused coverage for both transaction modes.
Pull request overview
Bootstraps the SLES base userland before installing application RPMs to prevent package scriptlet failures.
Changes:
- Adds configurable separate base-package installation.
- Enables it for SLES 15.
- Tests combined and separate installation ordering.
File summaries
| File | Description |
|---|---|
targets/linux/rpm/suse/sles15.go |
Enables separate bootstrapping for SLES 15. |
targets/linux/rpm/distro/distro.go |
Adds the configuration option. |
targets/linux/rpm/distro/container.go |
Implements ordered installation transactions. |
targets/linux/rpm/distro/container_test.go |
Verifies installation ordering. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install the SLES base userland before the application RPM and its runtime dependency graph. This prevents package scriptlets from invoking a partially installed shell while preserving the existing combined transaction for other RPM targets.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: