Replace type suppression with proper type narrowing in rating middleware - #108
Merged
Conversation
Merged
Co-authored-by: Jan0707 <1663330+Jan0707@users.noreply.github.com>
Co-authored-by: Jan0707 <1663330+Jan0707@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot
AI
changed the title
[WIP] Update podcast ratings implementation based on feedback
Replace type suppression with proper type narrowing in rating middleware
Jan 20, 2026
Jan0707
marked this pull request as ready for review
January 20, 2026 15:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #105 regarding the
@ts-ignorecomment in the rating middleware. The regex validatesvoteis either "up" or "down", but TypeScript infersstringfrom the regex match, requiring type assertion forcreateRating().Changes
@ts-ignorewith explicit type guard checking for'up'or'down'Example
Before:
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.