Skip to content

add libclang in the nix development shell - #24

Merged
programmersd21 merged 1 commit into
programmersd21:mainfrom
Sreehari425:nix-fix
Sep 18, 2026
Merged

programmersd21 merged 1 commit into
programmersd21:mainfrom
Sreehari425:nix-fix

Conversation

@Sreehari425

@Sreehari425 Sreehari425 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

same as title,

also this prevent ffmpeg-sys-next builds from failing when host libclang is incomplete.

Summary by Sourcery

Provide a complete, reproducible libclang environment for Nix development and builds.

Bug Fixes:

  • Ensure builds use the Nix-provided libclang so ffmpeg-sys-next does not depend on an incomplete host installation.

Enhancements:

  • Add libclang to the Nix development shell and package build environment, exposing its library path through LIBCLANG_PATH.

Build:

  • Add and lock the flake dependency metadata required for the updated Nix development and build configuration.

Summary by CodeRabbit

  • Chores
    • Updated the project’s development and build environments to include required LLVM/Clang tooling.
    • Configured the appropriate library path consistently for local development and package builds.
    • No user-facing functionality or public interfaces changed.

@sourcery-ai

sourcery-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The flake now supplies a pinned libclang toolchain dependency, makes it available during package builds and in the development shell, and configures LIBCLANG_PATH so bindgen-based dependencies such as ffmpeg-sys-next do not rely on an incomplete host installation.

File-Level Changes

Change Details Files
Provision libclang through the Nix flake for both package builds and the development shell.
  • Expose the LLVM package set and add libclang as a native build input.
  • Set LIBCLANG_PATH to the flake-provided libclang library directory during builds and development.
  • Add libclang to development-shell tools alongside the Rust toolchain utilities.
  • Add the generated flake lock file to pin Nix inputs.
flake.nix
flake.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1a4124d5-0dc4-4245-a66f-5a2a90196a27

📥 Commits

Reviewing files that changed from the base of the PR and between f034e2e and 9203338.

⛔ Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • flake.nix

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The Nix flake adds an LLVM package binding. The wallr package and default development shell now include llvmPackages.libclang and set LIBCLANG_PATH to its library directory.

Changes

LLVM Clang environment

Layer / File(s) Summary
Package and shell libclang configuration
flake.nix
The flake binds llvmPackages. The wallr package and default development shell include llvmPackages.libclang and set LIBCLANG_PATH.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 92033

The change directly addresses the reported ffmpeg-sys-next build environment issue without introducing an identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding libclang to the Nix development shell. It also aligns with the LIBCLANG_PATH configuration included in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@programmersd21
programmersd21 merged commit f5a3e17 into programmersd21:main Sep 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants