[FEATURE] Add Pull to Next at the bottom of Feed#1007
Open
paolorotolo wants to merge 3 commits intoprof18:mainfrom
Open
[FEATURE] Add Pull to Next at the bottom of Feed#1007paolorotolo wants to merge 3 commits intoprof18:mainfrom
paolorotolo wants to merge 3 commits intoprof18:mainfrom
Conversation
# Conflicts: # sharedUI/src/commonMain/kotlin/com/prof18/feedflow/shared/ui/home/components/HomeScreenContent.kt
paolorotolo
force-pushed
the
feature/pull-to-next
branch
from
1c2428e to
8a49bcb
Compare
Author
|
@prof18 conflict solved, it's ready for review now! |
prof18
requested changes
Mar 17, 2026
Owner
prof18
left a comment
prof18
left a comment
There was a problem hiding this comment.
Thank you so much for the contribution, really appreciated and sick ui! 💪
I left some minor comments! 🙏 Let me know if you can tackle them, otherwise no problem, I can take them 🙏
Comment on lines
+143
to
+145
| // nextFeedFilterMutableState.update { | ||
| // getNextFeedFilterOrNullUseCase(feedFilter) | ||
| // } |
Owner
There was a problem hiding this comment.
Suggested change
| // nextFeedFilterMutableState.update { | |
| // getNextFeedFilterOrNullUseCase(feedFilter) | |
| // } |
let's remove it :D I guess it's a leftover
| import com.prof18.feedflow.shared.domain.feed.FeedSourcesRepository | ||
| import kotlinx.coroutines.flow.first | ||
|
|
||
| class GetNextFeedFilterOrNullUseCase internal constructor( |
Owner
There was a problem hiding this comment.
Would you mind adding a test for this usecase? You can use the existing infra with koin to use a real FeedSourcesRepository.
Otherwise let me know, i can add it later no problem at all
| val title: String, | ||
| ) : NextFeedDisplayState() | ||
|
|
||
| class NextFeedDisplayDisabledState : NextFeedDisplayState() |
|
|
||
| @Stable | ||
| sealed class NextFeedDisplayState { | ||
| class NextFeedDisplayEnabledState( |
Owner
There was a problem hiding this comment.
Shouldn't be a data class? To help compose with recomposition etc
prof18
reviewed
Mar 17, 2026
| ) | ||
| Icon( | ||
| imageVector = Icons.Default.KeyboardArrowUp, | ||
| contentDescription = "Next", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new Pull to Next feature.
When reaching the bottom of a feed in Category - Source mode, it's now possible to pull up to preview the next unread feed and let go to navigate to it.
Demo
Navigation between categories
navigate.categories.mov
Navigation between Feed sources
Screen.Recording.2026-03-10.at.16.44.46.mov