Fixed off by one indexing for nonstationary transitions in backwards filter#436
Merged
Conversation
…omparing hmm_two_filter_smoother and hmm_smoother for non-stationary kernel.
slinderman
requested changes
Dec 1, 2025
Update transition matrix retrieval to use t-1.
Contributor
Author
|
Test failure turned out to be a disagreement between Jax and Tensorflow which is resolved by using slightly older Jax in requirements. Tests now pass except:
I don't really understand what this test is doing because I'm new to Jax-- any guidance? Neither test is related (as far as I can tell) to the change I made in the backward filter. |
…k with the latest jax versions more reliably.
Collaborator
|
I did some digging into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test comparing hmm_two_filter_smoother and hmm_smoother for non-stationary kernel.