Repository navigation
channeld: hold shutdown until a signed splice locks - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BOLT 2 says a node must not send
shutdownwhile a splice transaction is unlocked. channeld now holds ourshutdownwhile a splice both sides have signed is pending, and sends it once the splice locks. If the peer sendsshutdownfirst, we reply right away, since waiting on a peer that may never lock the splice would hang the close.splice_initonce either side has sentshutdown. An RBF of the pending splice is still accepted while ourshutdownis held.CHANNELD_SHUTTING_DOWN, including after a restart, and handles a splice lock in that state without announcing the new scid.CHANNELD_SHUTTING_DOWN, and the splice is still broadcast.--dev-shutdown-during-splicesendsshutdownwithout waiting, to test peers that do not hold it.test_splice_holds_shutdown_until_lockedcovers the hold, an RBF while held, a restart while held, and a mutual close of the locked splice output.Changelog-None