Open
Conversation
Author
|
Btw looks like these same tests that failed are failing in master |
Author
|
What are your thoughts on this @faresd ? |
Contributor
|
@alistairholt can you help here? |
Collaborator
|
@faresd sure. I'll take a look. |
Collaborator
|
@zjwhitehead thanks for your contribution and apologies for the massive delay in responding. While it works it feels slightly icky that we would return a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when adding a date field to a template and calling a document that doesnt yet have that date filled out the SDK raises an error because it cant convert an empty string or
nilto a Date/Time.It will still raise an error for malformed dates.
This fixes it by returning an empty text fragment (so calling
.value) still works.I thought about a few other approaches but this seems to have the lowest impact. Open to feedback