Skip to content

perf(client-generator-ts,client-generator-js): read the search queue by index instead of shift() #30199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lpbonomi wants to merge 1 commit into
base: v7
Choose a base branch
from
+6 −2
Open

perf(client-generator-ts,client-generator-js): read the search queue by index instead of shift() #30199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/client-generator-js/src/GenericsArgsInfo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ export class GenericArgsInfo {
const toVisit: ToVisitItem[] = [{ type: topLevelType }]
const visited = new Set<DMMF.InputType>()
let item: ToVisitItem | undefined
while ((item = toVisit.shift())) {
// read the queue by index: it grows to hundreds of thousands of items and `shift()` is linear in its length
let head = 0
while ((item = toVisit[head++])) {
const { type: currentType } = item
const cached = this._cache.get(currentType)
if (cached === true) {
Expand Down
4 changes: 3 additions & 1 deletion packages/client-generator-ts/src/GenericsArgsInfo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ export class GenericArgsInfo {
const toVisit: ToVisitItem[] = [{ type: topLevelType }]
const visited = new Set<DMMF.InputType>()
let item: ToVisitItem | undefined
while ((item = toVisit.shift())) {
// read the queue by index: it grows to hundreds of thousands of items and `shift()` is linear in its length
let head = 0
while ((item = toVisit[head++])) {
const { type: currentType } = item
const cached = this._cache.get(currentType)
if (cached === true) {
Expand Down