Skip to content

docs: bucket deletion cascades — update limitation comments#139

Merged
sorenbs merged 1 commit into
mainfrom
chore/bucket-cascade-comments
Jul 21, 2026
Merged

docs: bucket deletion cascades — update limitation comments#139
sorenbs merged 1 commit into
mainfrom
chore/bucket-cascade-comments

Conversation

@sorenbs

@sorenbs sorenbs commented Jul 21, 2026

Copy link
Copy Markdown
Member

Linked issue

n/a — small change

Summary

The Management API is gaining cascade semantics for bucket deletion (a bucket is deleted together with its objects, matching database deletion) via an in-flight pdp-control-plane change. This updates the two comments that documented the old "non-empty bucket delete returns 500" limitation: the Bucket provider's delete hook now documents the cascade contract, and the e2e verify's cleanup DELETE is re-justified as CRUD-round-trip coverage rather than a destroy prerequisite.

Merge after the control-plane cascade change deploys — until then the old limitation still holds in production.

Testing performed

  • Comment-only diff; pnpm turbo typecheck --filter @internal/lowering clean locally.
  • The bucket e2e job on this PR exercises the same deploy/verify/destroy path either way (verify empties the bucket before destroy, so it passes under both old and new server semantics).

Checklist

  • All commits are signed off (git commit -s) per the DCO. The DCO status check will block merge if any commit is missing a Signed-off-by: trailer.
  • I read CONTRIBUTING.md and the change is scoped to one logical concern.
  • The PR title is a conventional commit (feat, fix, chore, docs, refactor, test, build) — PR titles drive the auto-generated release notes.
  • Tests are updated (or n/a if the change is doc-only / refactor with no behavioural delta). — n/a, comment-only.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Søren Bramer Schmidt <sorenbs@gmail.com>
@pkg-pr-new

pkg-pr-new Bot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@prisma/composer@139
npm i https://pkg.pr.new/@prisma/composer-prisma-cloud@139

commit: 6b0d4f2

@sorenbs
sorenbs requested a review from wmadden July 21, 2026 07:57
@sorenbs
sorenbs merged commit 842c125 into main Jul 21, 2026
17 checks passed
@sorenbs
sorenbs deleted the chore/bucket-cascade-comments branch July 21, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants