Repository navigation
fix(semdiff): error instead of panicking when the embedder returns no vectors - #17
Merged
Merged
Conversation
… vectors
HTTPEmbedder.Embed returned whatever the endpoint sent, and embedOne indexed
vs[0] unchecked, so a 200 {"data":[]} panicked the handler goroutine and,
with no recovery interceptor, killed the priompt server on DiffPrompt and
publish. Embed now requires one non-empty vector per input and embedOne
guards the result.
Fixes #12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12.
An embeddings endpoint that answers
200 {"data":[]}(misconfigured proxy, wrong model, partial outage) madeembedOneindexvs[0]on an empty slice. The priompt server has no recovery interceptor, so the panic killed the whole process onDiffPromptand publish.HTTPEmbedder.Embedreturns an error unless it gets exactly one non-empty vector per input text.embedOneguards the result too, so any customEmbeddergets the same protection.Tested
TestEmbedderWithNoVectorsErrorscovers an httptest endpoint returning no data, anEmbedderreturningnil, and one returning an empty vector.mainthe test panics withindex out of range [0] with length 0; with this change it passes.go vet ./...andgo test ./...pass.Once this is tagged, bump proto in priompt.