Repository navigation
docs: make JavaScript README examples safe to copy - #34
Closed
MatheoPaiva wants to merge 1 commit into
Closed
MatheoPaiva wants to merge 1 commit into
MatheoPaiva wants to merge 1 commit into
Conversation
MatheoPaiva
requested review from
iamDyeus and
sujal-maheshwari2004
as code owners
November 15, 2026 04:54
Member
|
Hi @MatheoPaiva, thank you for taking the time to send this. We're closing it, and it's not about the quality of the change. The issue it fixes is labelled If you'd like to keep contributing, we'd welcome help on our Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23
Fixes #24
Make the CommonJS quick-start valid in a
.jsfile by movingawaitinto an async function and handling errors. Update the subscription examples to await the returned NATS connection, handle startup errors, and close both connections when the app stops.Validation: extracted quick-start and live-update snippets pass
node --checkon Node v24.18.0. Mock-client smoke checks passed for quick-start cleanup, rejected subscription handling, and SIGINT cleanup of both connections. The project test suite was not run because this changes README examples only.AI assistance: prepared with OpenAI Codex.