Repository navigation
Percent-decode token in priompt:// connection URLs - #31
Closed
techkayacodes wants to merge 2 commits into
Closed
techkayacodes wants to merge 2 commits into
techkayacodes wants to merge 2 commits into
Conversation
Member
|
Hi @techkayacodes, thank you for taking the time to send this. We're closing it, and it's not about the quality of the change. The issue it fixes is labelled If you'd like to keep contributing, we'd welcome help on our Thanks again! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseUrl()previously returnedu.usernameraw without percent-decoding, causing base64 or special-character tokens escaped inpriompt://<token>@host:portURLs (such as+,=,/) to be sent still percent-encoded in theAuthorizationheader.This updates
parseUrl()to decodeu.usernamewithdecodeURIComponent(u.username)(matchingparseNatsUrland the Go CLI) and adds unit test coverage intest/token.test.jsfor bothPRIOMPT_URLand theurloption.Fixes #27