Skip to content

Revert "UnderlineNav: Replace dynamic icon visibility logic with hardcoded breakpoints"#8186

Closed
francinelucca wants to merge 3 commits into
mainfrom
revert-8133-underlinenav-hardcoded-breakpoints
Closed

Revert "UnderlineNav: Replace dynamic icon visibility logic with hardcoded breakpoints"#8186
francinelucca wants to merge 3 commits into
mainfrom
revert-8133-underlinenav-hardcoded-breakpoints

Conversation

@francinelucca

@francinelucca francinelucca commented Jul 17, 2026

Copy link
Copy Markdown
Member

Reverts #8133

@changeset-bot

changeset-bot Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 254a4c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. If this doesn't work, you can also use the original workflow here. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@github-actions
github-actions Bot requested a deployment to storybook-preview-8186 July 17, 2026 15:07 Abandoned
@github-actions
github-actions Bot requested a deployment to storybook-preview-8186 July 17, 2026 15:12 Abandoned
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8186 July 17, 2026 15:22 Inactive
@primer-integration

primer-integration Bot commented Jul 17, 2026

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

@primer
primer Bot deleted the revert-8133-underlinenav-hardcoded-breakpoints branch July 21, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@francinelucca