Skip to content

fixed ecdsa_verify assertion failure #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
duckki wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed ecdsa_verify assertion failure #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cryptos/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ def get_version_byte(inp):
leadingzbytes = len(re.match('^1*', inp).group(0))
data = b'\x00' * leadingzbytes + changebase(inp, 58, 256)
assert bin_dbl_sha256(data[:-4])[:4] == data[-4:]
return ord(data[0])
return ord(data[0:1])


def hex_to_b58check(inp, magicbyte=0):
Expand Down Expand Up @@ -570,12 +570,12 @@ def ecdsa_verify_addr(msg, sig, addr, coin):
assert coin.is_address(addr)
Q = ecdsa_recover(msg, sig)
magic = get_version_byte(addr)
return (addr == coin.pubtoaddr(Q, int(magic))) or (addr == coin.pubtoaddr(compress(Q), int(magic)))
return (addr == pubkey_to_address(Q, int(magic))) or (addr == pubkey_to_address(compress(Q), int(magic)))


def ecdsa_verify(msg, sig, pub, coin):
if coin.is_address(pub):
return ecdsa_verify_addr(msg, sig, pub, coin)
if coin.is_address(msg):
return ecdsa_verify_addr(msg, sig, coin.pubtoaddr(pub), coin)
return ecdsa_raw_verify(electrum_sig_hash(msg), decode_sig(sig), pub)


Expand Down